Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed menu theme for deprecated methods #219

Merged
merged 12 commits into from
Dec 29, 2023

Conversation

Loup-Garou911XD
Copy link
Collaborator

No description provided.

@Freaku17
Copy link
Collaborator

Error in new ver:

set_main_menu_window() should be passed a 'from_window' value to help ensure proper UI behavior (/storage/emulated/0/Android/data/net.froemling.bombsquad/files/mods/menu_theme.py line 1989).

@Loup-Garou911XD
Copy link
Collaborator Author

Yeah ik that warning, that's what I mentioned in discord

@Loup-Garou911XD
Copy link
Collaborator Author

We can fix that later

@Freaku17
Copy link
Collaborator

We can fix that later

Okay, whenever you feel comfortable 👍

@Loup-Garou911XD
Copy link
Collaborator Author

Yeah so we can merge

@Freaku17
Copy link
Collaborator

Yeah so we can merge

Yes, we can merge after we fix that

@Loup-Garou911XD
Copy link
Collaborator Author

Yeah so we can merge

Yes, we can merge after we fix that

its a warning rn so can we do that in a different pr

@Freaku17
Copy link
Collaborator

its a warning rn so can we do that in a different pr

Imo, since it is related to the current PR it should be done in the current one only & then merged.
Will hardly take few min to fix?

@Freaku17
Copy link
Collaborator

This still has a error, but made it easier for you

@Loup-Garou911XD
Copy link
Collaborator Author

Closes #213

@Freaku17
Copy link
Collaborator

@Loup-Garou911XD This still has the following error; I dunno how to fix...

  File "/storage/emulated/0/Android/data/net.froemling.bombsquad/files/mods/menu_theme.py", line 1481, in on_transition_in
    MainMenuWindow(transition=None).get_root_widget(), from_window=self._root_widget
                                                                   ^^^^^^^^^^^^^^^^^
AttributeError: 'MainMenuTheme' object has no attribute '_root_widget'
set_main_menu_window() was passed 'from_window' <bauiv1 'container' widget 0xb40000737e03bd00> but existing main-menu-window is None. (/data/data/net.froemling.bombsquad/no_backup/ballistica_files/ba_data/python/bauiv1lib/mainmenu.py line 1077).

@Loup-Garou911XD
Copy link
Collaborator Author

That's why I asked to fix that in a different commit
So that the plugin could be functional while we fix a warning

@Loup-Garou911XD
Copy link
Collaborator Author

Anyways I'll try to fix it today

Copy link
Collaborator

@Freaku17 Freaku17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm now 😄

@Freaku17 Freaku17 merged commit 3147334 into bombsquad-community:main Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants