NCP 리스트 API 버전업 #144
Merged
NCP 리스트 API 버전업 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5tarry
previously approved these changes
Nov 30, 2023
| @@ -16,6 +18,7 @@ export const listObjects = async (bucketName: string) => { | |||
| }; | |||
|
|
|||
| const method = 'GET'; | |||
| Object.assign(params, { 'list-type': 2 }); | |||
There was a problem hiding this comment.
GET /apiary?list-type=2 처럼 보내고 params에 따로 추가하지 않으면 동작이 안되는걸까요??
Comment on lines
+36
to
+37
| .then((response): any => xml2js(response.data, { compact: true })) | ||
| .then((element) => _.map(element.ListBucketResult.Contents, 'Key._text')); |
5tarry
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #143
작업 내용
전달 사항