Presigned URL 관련 예외처리 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5tarry
approved these changes
Nov 30, 2023
Comment on lines
+73
to
+80
| const result = await this.UserModel.findOneAndUpdate( | ||
| { uuid }, | ||
| updateOption, | ||
| { | ||
| lean: true, | ||
| new: true, | ||
| }, | ||
| ); |
Comment on lines
+89
to
+93
| return { | ||
| nickname: result.nickname, | ||
| statusMessage: result.statusMessage, | ||
| profileImageUrl, | ||
| }; |
There was a problem hiding this comment.
findOneAndObject에서 처음부터 선별한 field만 가져오는건 어떻게 생각하시나요?!
Comment on lines
+37
to
+52
| .then((element) => { | ||
| const contents = element.ListBucketResult.Contents; | ||
| if (Array.isArray(contents)) { | ||
| return _.map(contents, 'Key._text'); | ||
| } | ||
| if (contents) { | ||
| // eslint-disable-next-line no-underscore-dangle | ||
| return [contents.Key._text]; | ||
| } | ||
| return []; | ||
| }); | ||
| }; | ||
| export const checkUpload = async (bucketName: string, objectName: string) => { | ||
| const objectList = await listObjects(bucketName, { prefix: objectName }); | ||
|
|
||
| return objectList.includes(objectName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #157
작업 내용