Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

업로드 한 비디오 API 응답 데이터 수정 #212

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

5tarry
Copy link
Collaborator

@5tarry 5tarry commented Dec 4, 2023

resolved: #211

작업 내용

  • 특정 유저가 업로드 한 비디오 API 응답 데이터 형식을 다른 비디오 응답 형식과 동일하도록 변경
  • 회원가입 시 profileImageExtension이 없는 경우 null 처리

@5tarry 5tarry added backend refactor 코드 리팩토링 labels Dec 4, 2023
@5tarry 5tarry added this to the Week 5 milestone Dec 4, 2023
@5tarry 5tarry requested a review from msjang4 December 4, 2023 14:19
@5tarry 5tarry self-assigned this Dec 4, 2023
Copy link
Collaborator

@msjang4 msjang4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,7 +12,7 @@ export class UserDto {
* 프로필 이미지 확장자
* @example 'webp'
*/
profileImageExtension?: string;
profileImageExtension?: string | null = null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대박 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대박티비 📺

@msjang4 msjang4 merged commit 15b84a2 into develop Dec 4, 2023
@5tarry 5tarry deleted the fix/modify_uploaded_video_response branch December 8, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] 업로드 한 비디오 응답 데이터 변경
2 participants