-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clova GreenEye API 요청 #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유해이미지 검사 액션과 delete API간을 필요한 파라미터들을 잘 고려해주신 거 같아요
프로젝트 마감이 얼마 남지 않아서 지금은 넘어가는게 맞지만 ㅜㅜ 제 생각에는 admin용 token을 만들어서 액션에 유저 jwt를 넘겨주지 않고 delete API에서도 admin인 경우 업로더 본인체크를 안하는 건 어떤가 싶네요 🤔
전체적으로 너무 좋은 코드예요! 고생하셨어요 감사합니다 🙇🏻♂️
// eslint-disable-next-line no-await-in-loop | ||
const result = await greenEye(file, file, imageData, greenEyeSecret); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for문에서는 await를 하지 않는게 권장이군여
promise 패턴과 재귀를 활용해보면 좋을 수도..? 제가 한번 고민해볼게요
} | ||
} | ||
|
||
const createScreanshots = async (videoUrl) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
함수 내에서 await를 안하면 async를 안붙여도 되는데 이 함수처럼 promise를 리턴하는 경우 명시성을 위해 일부러 붙여주기도 하더라고요! 그런 점을 고려하신건지 궁금해요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 아마 깊게 고려하진 않았던 것 같아요
@@ -21,7 +21,7 @@ export class AuthGuard implements CanActivate { | |||
} | |||
try { | |||
const payload = await this.jwtService.verifyAsync(token); | |||
request.user = payload; | |||
request.user = { ...payload }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 이건 token 추가하려고 이렇게 했었어요 ㅎㅎ
resolved: #237
작업 내용
전달 사항