Use stdlibc++ 11 for Clang 13&14 and automatically install selected GCC toolchain #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids some more redundancy.
It is not fully compatible and might lead e.g. to undefined symbols related to `std::basic_string...:_M_construct` in C++20 mode with Unicode char types (`char16_t`, ...).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 22 22
Branches 10 10
=========================================
Hits 22 22 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some redundancy:
I did run into llvm/llvm-project#55560 with Clang 13 & 14 and libstdc++ 12 & 13 so downgrading to 11.
I'm not fully sure about Clang 15 as others use libstdc++ 11 with that too but I haven't seen issues with 12 so sticking to that for now.