Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable check for __float128 on PGI compiler #641

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Disable check for __float128 on PGI compiler #641

merged 1 commit into from
Nov 6, 2024

Conversation

mborland
Copy link
Member

@mborland mborland commented Nov 4, 2024

Fixes #640

Per config we should not have 128-bit float on this platform: https://github.com/boostorg/config/blob/19701e05d4832d1e97e06e791f2e4e1c7cba9b13/include/boost/config/compiler/pgi.hpp#L19.

Not sure if anything has happened in the 7 years since that commit was last updated...

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (0ab75f9) to head (5108a96).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #641     +/-   ##
=========================================
+ Coverage     92.5%   94.1%   +1.6%     
=========================================
  Files          254     279     +25     
  Lines        23475   28885   +5410     
=========================================
+ Hits         21699   27161   +5462     
+ Misses        1776    1724     -52     
Files with missing lines Coverage Δ
...nclude/boost/multiprecision/detail/number_base.hpp 98.0% <ø> (+0.2%) ⬆️

... and 165 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab75f9...5108a96. Read the comment docs.

@mborland
Copy link
Member Author

mborland commented Nov 6, 2024

The 3 failed run in circle all provide 0 information as to the failure, it's all build killed. Since GitHub actions and drone both show no problems it's likely safe to merge this. The issue reporter also says it fixed their problem.

@mborland mborland merged commit 92aaa55 into develop Nov 6, 2024
78 of 79 checks passed
@mborland mborland deleted the pgi branch November 6, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvc++ errors with message "float128_type is undefined"
1 participant