[Fix] Tmpdir Symbolic Links #610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flyboarder would you mind expanding on this change in a Changelog entry? Outlining previous and with-this-PR behavior in the PR would also be great as I'm not fully aware how Boot dealt with symlinks before. |
|
I'm not sure this is needed anymore, at the time I was seeing corrupt files being copied around because boot was breaking the symlinks. Needs more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows adding tmpdir folders which contain symbolic links. Symbolic links are visited by the file visitor, visitfile now checks if file is a symbolic link.