Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests missing for FreeBSD acl code #7745

Closed
ThomasWaldmann opened this issue Jul 28, 2023 · 2 comments
Closed

tests missing for FreeBSD acl code #7745

ThomasWaldmann opened this issue Jul 28, 2023 · 2 comments
Assignees
@ThomasWaldmann
Labels
help wanted os: bsd FreeBSD, NetBSD, OpenBSD, ... testsuite
Milestone
2.0.0rc1

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Jul 28, 2023 •
edited
Loading

borg has some platform specific code for ACLs on FreeBSD, but looks like there are no tests for that code (we only have ACL tests for Linux and macOS (darwin)).
@ThomasWaldmann ThomasWaldmann added help wanted testsuite os: bsd FreeBSD, NetBSD, OpenBSD, ... labels Jul 28, 2023
@ThomasWaldmann ThomasWaldmann added this to the 2.0.0rc1 milestone Jul 28, 2023
@ThomasWaldmann ThomasWaldmann mentioned this issue Jul 28, 2023
Merged
@bigtedde bigtedde mentioned this issue Jul 28, 2023
Merged
@bigtedde
Copy link
Contributor

Dummy file created for these tests. Find here.

@ThomasWaldmann ThomasWaldmann self-assigned this Aug 26, 2023
@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Aug 26, 2023 •
edited
Loading

the freebsd64 vagrant machines needs:

  • "acls" option in /etc/fstab.
  • group "wheel" (not "root") in acls

guess we can't test nfs4 acls, if we do not have a nfs v4 server and such a fs mounted?

ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Aug 27, 2023
@ThomasWaldmann
freebsd: add some ACL tests, fixes borgbackup#7745
ba697ce 
enable ACL support in freebsd vagrant machine's filesystem
ThomasWaldmann added a commit that referenced this issue Aug 27, 2023
@ThomasWaldmann
Merge pull request #7777 from ThomasWaldmann/freebsd-acl-tests-master
981c562 
freebsd: add some ACL tests, fixes #7745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
help wanted os: bsd FreeBSD, NetBSD, OpenBSD, ... testsuite
Projects
None yet
Milestone
2.0.0rc1
Development

No branches or pull requests
2 participants
@ThomasWaldmann @bigtedde