PR: testsuite/platform.py conversion to pytest + remove BaseTestCase

[bigtedde]

This is one of the last remaining files in the test suite to have quite a bit of unittest and BaseTestCase usages, so I split it into its own PR. Will convert all unittest to pytest, remove BaseTestCase entirely, and rename some tests to follow the naming conventions of the classes they are being pull from.

[codecov-commenter]

Codecov Report

Merging #7743 (8eed958) into master (f33efc0) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7743      +/-   ##
==========================================
+ Coverage   83.65%   83.67%   +0.01%     
==========================================
  Files          66       66              
  Lines       11915    11915              
  Branches     2159     2159              
==========================================
+ Hits         9968     9970       +2     
+ Misses       1371     1370       -1     
+ Partials      576      575       -1     

see 1 file with indirect coverage changes

[bigtedde]

All checks passed, same test coverage before and after. Unittest removed as well as BaseTestCase. Marking as ready for review 👍

[ThomasWaldmann]

Hmm, now that the test class is gone that functioned as container per platform, you needed to put the platform name in all the function names.

Maybe it would be good to split this into multiple modules for linux, darwin, posix.

[bigtedde]

Maybe it would be good to split this into multiple modules for linux, darwin, posix.

Split into three modules: platform_linux.py, platform_darwin.py, platform_posix.py?

[ThomasWaldmann]

LGTM.

One thing I noticed: we have freebsd platform code, but no freebsd acl tests.
Implementing them would be out of scope of this PR of course, but maybe you could create some sort of dummy platform_freebsd.py test file that has some skipped tests due to "not implemented".

After you have created the dummy file, please add a comment to #7745.

[bigtedde]

One thing I noticed: we have freebsd platform code, but no freebsd acl tests. Implementing them would be out of scope of this PR of course, but maybe you could create some sort of dummy platform_freebsd.py test file that has some skipped tests due to "not implemented".

After you have created the dummy file, please add a comment to #7745.

Okay, I can do that. I will create a separate PR for that one.

[bigtedde]

LGTM.

Excelent! I have marked this as ready for review. Please let me know if there is anything you would like changed in this PR before merging.