List more archive metadata #8422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to change this because listing just the archive names is pretty useless if names are not unique. The short list is likely mostly used by scripts to iterate over all archives, so outputting IDs is better.
ThomasWaldmann
force-pushed
the
list-more-archive-metadata
branch
from
ca9eb74
to
00cb731
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8422 +/- ##
==========================================
+ Coverage 81.54% 81.55% +0.01%
==========================================
Files 70 70
Lines 12779 12779
Branches 2317 2317
==========================================
+ Hits 10420 10422 +2
+ Misses 1701 1700 -1
+ Partials 658 657 -1 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
force-pushed
the
list-more-archive-metadata
branch
2 times, most recently
from
3c2a49d
to
a06c7dd
Compare
…adjust borg 1.x encouraged users to put everything into the archive name: - name of the dataset - timestamp (usually used to make the archive name unique) - maybe also hostname (when backing up to same repo from multiple hosts) - maybe also username (when backing up to same repo from multiple users) borg2 now discourages users from putting the timestamp into the name, because we rather want same name within a series of archives - thus, the field width for the name can be narrower. the ID of the archive is now the only unique identifier, thus it is moved to the leftmost place. 256bits (64 hex digits) was a bit much and as borg can also deal with abbreviated IDs, we only show 32bits (8 hex digits) by default. the ID is followed by the timestamp (also quite "interesting", because it usually differs for different archives). then following are: archive name, user name, host name - these might be always the same if there is only one series of archives in a repo. use 2 blanks separating the fields for better readability.
ThomasWaldmann
force-pushed
the
list-more-archive-metadata
branch
from
a06c7dd
to
9b3a002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this now:
See the commit comments for the reasoning.