Sigv4a signing region set config bugfix #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the sigv4a_signing_region_set configuration in the config file and the corresponding environment variable would be ignored
nateprewitt
requested changes
Oct 15, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3279 +/- ##
========================================
Coverage 93.17% 93.18%
========================================
Files 66 66
Lines 14339 14345 +6
========================================
+ Hits 13361 13367 +6
Misses 978 978 ☔ View full report in Codecov by Sentry. |
hssyoo
reviewed
Oct 15, 2024
aemous
reviewed
Oct 15, 2024
nateprewitt
requested changes
Oct 15, 2024
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
nateprewitt
force-pushed
the
sigv4a-signing-region-set-config-bugfix
branch
from
fb7cd10
to
b03041b
Compare
nateprewitt
approved these changes
Oct 16, 2024
aws-sdk-python-automation
added a commit
that referenced
this pull request
Oct 16, 2024
* release-1.35.42: Bumping version to 1.35.42 Update to latest models Merge customizations for S3 Sigv4a signing region set config bugfix (#3279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the sigv4a_signing_region_set configuration in the config file and the corresponding environment variable would be ignored