Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sigv4a signing region set config bugfix #3279

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Sigv4a signing region set config bugfix #3279

merged 9 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Bugfix: sigv4a signing region set config variable bug 

    Fixes a bug where the sigv4a_signing_region_set configuration in the config file and the corresponding environment variable would be ignored
    @SamRemis
    SamRemis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1fe7bcc View commit details
    Browse the repository at this point in the history

  2. Run pre-commit over changes

    @SamRemis
    SamRemis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    23ef82a View commit details
    Browse the repository at this point in the history

  3. Add test

    @SamRemis
    SamRemis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6f9adef View commit details
    Browse the repository at this point in the history

  4. Update test_auth_config.py

    @SamRemis
    SamRemis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2ca663c View commit details
    Browse the repository at this point in the history

  5. Update test_auth_config.py

    @SamRemis
    SamRemis committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a083aa5 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
    @SamRemis @nateprewitt
    SamRemis and nateprewitt authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac83bc1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Updates based on feedback

    @SamRemis
    SamRemis committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a2d9a78 View commit details
    Browse the repository at this point in the history

  2. Update test_auth_config.py

    @SamRemis
    SamRemis committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a7d1205 View commit details
    Browse the repository at this point in the history

  3. Refactor test to remove conditionals from test code

    @nateprewitt
    nateprewitt committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b03041b View commit details
    Browse the repository at this point in the history