defaults-helper: rerun on changes to any file in defaults.d #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-berning
approved these changes
Jan 3, 2025
cbgbt
force-pushed
the
rerun-on-defaults-changes
branch
from
0d420c9 to
6d163fc
Compare
|
^ Fixes commit message |
yeazelm
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes bottlerocket-os/twoliter#422
Description of changes:
Per bottlerocket-os/twoliter#422, adding a symlink to a
defaults.ddirectory does not result in a rebuild of defaults generated bybottlerocket-defaults-helper.This is because we were emitting
cargo::rerun-if-changeddirectives for each file discovered in the defaults directory, but not scanning the directory itself for new files.This changes
bottlerocket-defautls-helperto emit a singlererun-if-changeddirective for the entiredefaults.ddirectory, which will result in cargo scanning the directory for changes when detecting rebuilds.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.