Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant YYLOC global declaration #29

Open
wants to merge 1 commit into
base: lineage-15.1-64
Choose a base branch
from
Open

Remove redundant YYLOC global declaration #29

wants to merge 1 commit into from

Commits on Feb 26, 2021

  1. Remove redundant YYLOC global declaration 

    Following Tomoms/android_kernel_oppo_msm8974@11647f9

gcc 10 will default to -fno-common, which causes this error at link time:

  (.text+0x0): multiple definition of `yylloc'; dtc-lexer.lex.o (symbol from plugin):(.text+0x0): first defined here

This is because both dtc-lexer, as well as dtc-parser, define the same global symbol yyloc.
Before with -fcommon those were merged into one definition.

Marking the symbol as extern seems sufficient in contrast to the above-linked commit message.
Removing it breaks as described there breaks the build.
    @gothicVI
    gothicVI authored Feb 26, 2021
    Configuration menu
    Copy the full SHA
    45937e7 View commit details
    Browse the repository at this point in the history