-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for additional fields in SignRequest
#919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Please also check comments
expect(signRequest?.redirectUrl).to(equal(signParameters.redirectUrl)) | ||
expect(signRequest?.declinedRedirectUrl).to(equal(signParameters.declinedRedirectUrl)) | ||
expect(signRequest?.parentFolder.id).to(equal(rootFolder.id)) | ||
expect(signRequest?.signFiles?.files?.count).to(equal(2)) | ||
// first signer is the sender with role final_copy_reader, second and third is the recipient with role signer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also possible to assert roles in this test?
@@ -77,6 +77,22 @@ public class SignRequestSigner: BoxModel { | |||
public let redirectUrl: String? | |||
/// The URL that a signer will be redirect to after declining to sign a document. | |||
public let declinedRedirectUrl: String? | |||
/// This URL is specifically designed for signing documents within an HTML `iframe` tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space between "for" and "signing". I saw it's like this in the spec so maybe we shouldn't care about it.
Also consider another name for this PR as it's adding much more than a single field |
signer_group_id
field in SignRequest
SignRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
No description provided.