happy new year - unit tests for exchange factory

boxblinkracer · Jan 1, 2024 · 5cf8617 · 5cf8617
1 parent cc53146
commit 5cf8617
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Bundles/Exchange/ExchangeFactory.php b/src/Bundles/Exchange/ExchangeFactory.php
@@ -99,7 +99,7 @@ public function getAllOptions(): array
      */
     public function getExchange(string $format, array $options): ExchangeInterface
     {
-        if ($format === '' || $format === '0') {
+        if ($format === '') {
             throw new Exception('No format name provided for the Exchange service');
         }
 

diff --git a/tests/phpunit/Bundles/Exchange/ExchangeFactoryTest.php b/tests/phpunit/Bundles/Exchange/ExchangeFactoryTest.php
@@ -7,6 +7,7 @@
 use phpunit\Utils\Fakes\FakeExchangeFormat;
 use PHPUnuhi\Bundles\Exchange\ExchangeFactory;
 use PHPUnuhi\Exceptions\ConfigurationException;
+use PHPUnuhi\Models\Command\CommandOption;
 
 class ExchangeFactoryTest extends TestCase
 {
@@ -69,4 +70,18 @@ public function testEmptyFormatThrowsException(): void
 
         ExchangeFactory::getInstance()->getExchange('', []);
     }
+
+    /**
+     *
+     */
+    public function testGetAllOptions(): void
+    {
+        $options = ExchangeFactory::getInstance()->getAllOptions();
+
+        $expected = [
+            new CommandOption('csv-delimiter', true),
+        ];
+
+        $this->assertEquals($expected, $options);
+    }
 }