You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Issue #5 references a way to override the config via dnsmasq::config class but that class was removed. There is reference to a $configfile param but it is not used. I'm going to fix in my personal fork. If would like me to submit a PR, help me understand how $configfile was intended to be used: a source, a template, or something else entirely?
The text was updated successfully, but these errors were encountered:
Hi,
What is the plan to fix the overriding of the dnsmasq.conf file? Because now I have to do a bit of a nasty hack to add additional entries to this file, but a nice way to override it would be cool... The repository of erik-stephens doesn't work, because it doesn't start dnsmasq with the correct config file (that is probably the reason why that $configfile variable is still there...)
Yeah, not sure why I commented out $configfile in my fork, maybe to indicate that it's not used. I think I searched for $configfile but after looking again, I see it referenced in an erb template as @configfile - lesson learned when grep'ing puppet modules. Not tested but I did undo that comment so the daemon should start now.
Longer term, maybe have the config file driven by a hash variable? I'm not sure worth the effort. Putting the onus of managing the config file on the boxen user and not this module might be best.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Issue #5 references a way to override the config via dnsmasq::config class but that class was removed. There is reference to a $configfile param but it is not used. I'm going to fix in my personal fork. If would like me to submit a PR, help me understand how
$configfile
was intended to be used: a source, a template, or something else entirely?The text was updated successfully, but these errors were encountered: