pkp/pkp-lib#9959 use createTextNode for article title in order to esc…

…apt it (e.g. &) properly
bozana · May 13, 2024 · 3c57d18 · 3c57d18
1 parent c19d840
commit 3c57d18
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/filter/ArticleCrossrefXmlFilter.php b/filter/ArticleCrossrefXmlFilter.php
@@ -121,7 +121,8 @@ public function createJournalArticleNode($doc, $submission)
         $languageCounter = 1;
         foreach ($titleLanguages as $lang) {
             $titlesNode = $doc->createElementNS($deployment->getNamespace(), 'titles');
-            $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title', $publication->getLocalizedTitle($lang, 'html')));
+            $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title'));
+            $node->appendChild($doc->createTextNode($publication->getLocalizedTitle($lang, 'html')));
             if ($subtitle = $publication->getLocalizedSubTitle($lang, 'html')) {
                 $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'subtitle', $subtitle));
             }
@@ -134,8 +135,7 @@ public function createJournalArticleNode($doc, $submission)
 
         // contributors
         $authors = $publication->getData('authors');
-
-        if (!empty($authors)) {
+        if ($authors->count() != 0) {
             $contributorsNode = $doc->createElementNS($deployment->getNamespace(), 'contributors');
 
             $isFirst = true;