pkp/pkp-lib#9959 use createTextNode for article title and subtitle in…

… order to escapt it (e.g. &) properly
bozana · May 22, 2024 · 56a573f · 56a573f
1 parent b3f2990
commit 56a573f
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/filter/ArticleCrossrefXmlFilter.php b/filter/ArticleCrossrefXmlFilter.php
@@ -121,10 +121,12 @@ public function createJournalArticleNode($doc, $submission)
         $languageCounter = 1;
         foreach ($titleLanguages as $lang) {
             $titlesNode = $doc->createElementNS($deployment->getNamespace(), 'titles');
-            $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title', $publication->getLocalizedTitle($lang, 'html')));
+            $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'title'));
+            $node->appendChild($doc->createTextNode($publication->getLocalizedTitle($lang, 'html')));
             if ($subtitle = $publication->getLocalizedSubTitle($lang, 'html')) {
-                $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'subtitle', $subtitle));
-            }
+                $titlesNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'subtitle'));
+                $node->appendChild($doc->createTextNode($subtitle));
+                }
             $journalArticleNode->appendChild($titlesNode);
             $languageCounter++;
             if ($languageCounter > 20) {
@@ -135,7 +137,7 @@ public function createJournalArticleNode($doc, $submission)
         // contributors
         $authors = $publication->getData('authors');
 
-        if (!empty($authors)) {
+        if ($authors->count() != 0) {
             $contributorsNode = $doc->createElementNS($deployment->getNamespace(), 'contributors');
 
             $isFirst = true;