-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no outgoing from task #52
Conversation
lib/handler/attachersHandler.js
Outdated
@@ -12,7 +12,7 @@ export default { | |||
const nextElements = []; | |||
|
|||
const attachedOutgoing = (element.attachers || []) | |||
.map(att => att.outgoing.reverse()) | |||
.map(att => (att.outgoing ? att.outgoing.reverse() : [])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Null object pattern, again:
.map(att => (att.outgoing ? att.outgoing.reverse() : [])) | |
.map(attacher => (attacher.outgoing || []).reverse()) |
Closes #45
8a6b773
to
04592f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case could be slightly "less verbose", but hey, it works as an integration test (checking many more things than needed for this example) now.
Do we actually use the tests and try to generate (and verify the generation succeeds)?
Agreed.
Do you mean generating bpmn file from layout XML? We can also add test cases to generate the file. |
Closes #45
Proposed Changes
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}