Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight across inserts #5

Open
Skaiir opened this issue Mar 2, 2023 · 0 comments
Open

Highlight across inserts #5

Skaiir opened this issue Mar 2, 2023 · 0 comments
Labels
backlog bug Something isn't working spring cleaning

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Mar 2, 2023

Describe the Bug

Currently when we interrupt some markdown with inserts, it breaks the underlying syntax tree and hence highlighting:
image

Fixing this is far from trivial, as we probably would have to invert the way we parse things, starting with the underlying language and then adding an overlay language mixin on top of it (described here).

However we definitely don't want that for the interpreter parser. So we'd need two mixed languages.

For now, I would advise against working on this.

Steps to Reproduce

  1. npm run start
  2. add some text with bold markdown tags
  3. add an insert inside of those tags
  4. the syntax highlighting breaks

Expected Behavior

  1. Syntax highlighting should remain, and the new styles should just be painted on top.
@Skaiir Skaiir added the bug Something isn't working label Mar 2, 2023
@nikku nikku added the backlog label Mar 3, 2023 — with bpmn-io-tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog bug Something isn't working spring cleaning
Projects
None yet
Development

No branches or pull requests

3 participants