chore: improve feelers documentation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Oct 20, 2023
|
|
||
| If your string is prefixed with an =, it will be evaluated as a single FEEL expression. | ||
|
|
||
| ```js |
There was a problem hiding this comment.
I find this aspect interesting and would expect, as a template engine, feelers only operates on strings, never on expressions.
This ties to the spirit of "do one thing and do it right": I'd rather not have it in feelers, but outside. This otherwise ties feelers to core features some random engine or tooling decided upon.
My cents. Maybe there is room to improve this.
Adding this PR (and the insights I gained reviewing it) is a great example for readme driven development, and how explaining before building can help us to shape ideas (and build simple, focused, and easy to understand things.
There was a problem hiding this comment.
@Skaiir Did you consider my comment, i.e. does it make sense?
Skaiir
force-pushed
the
improve-readme
branch
from
be32de6
to
fbde9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.