fix(VariableResolver): correctly filter out already existing properties #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
philippfromme and
barmac
and removed request for
a team
barmac
reviewed
Mar 7, 2024
|
|
||
| target[property].push(...originToAdd); | ||
| target[property].push(...propertiesToAdd); |
There was a problem hiding this comment.
If spread can cause problems, why do we keep using it?
Suggested change
| target[property].push(...propertiesToAdd); | |
| target[property] = target[property].concat(propertiesToAdd); |
There was a problem hiding this comment.
As a (desired) side effect of using .push, we modify the original array, which is referenced from nested variables as well. So you will get the correct list of origins for a (sub-)variable even when it was added through mappings.
The Stack index was only a symptom of another problem, so it should be safe to use it
barmac
approved these changes
Mar 8, 2024
|
Let's get this released and integrated + give web modeler a heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to camunda/camunda-modeler#4139
root cause in this comment: camunda/camunda-modeler#4139 (comment)