Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default URL scheme in sphinx-sitemap to exclude language. #73

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Sphinx-sitemap introduced a /en/ path to all urls causing them to be invalid.

What does this PR do?
Sets the sitemap-url-scheme to only generate the link, without appending language or version.

References

How has this PR been tested?

The site builds locally, sitemap checked by eye and links were followed to ensure they're working.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally

@IgorTatarnikov IgorTatarnikov requested a review from a team October 20, 2023 15:35
@adamltyson adamltyson merged commit 5c2f52d into main Oct 20, 2023
2 checks passed
@adamltyson adamltyson deleted the fix-sphinx-sitemap branch October 20, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants