fix: changed error detection from stderr to command return code to prevent yarn warnings from crashing license-auditor process

packages/core/src/dependency-finder/exec-command.ts

@@ -2,14 +2,19 @@ import { exec } from "node:child_process";
 
 import { ExecCommandException } from "../exceptions/index.js";
 
+type ExecCommandResult = {
+  stdout: string;
+  stderr: string;
+};
+
 export async function execCommand(
   command: string,
   cwd: string,
   verbose?: boolean | undefined,
-): Promise<string> {
+): Promise<ExecCommandResult> {
   return new Promise((resolve, reject) => {
     exec(command, { cwd }, (error, stdout, stderr) => {
-      if (error || (stderr && !stderr.includes("Debugger attached"))) {
+      if (error) {
         reject(
           new ExecCommandException(
             error?.stack && verbose
@@ -24,7 +29,7 @@ export async function execCommand(
         );
       }
 
-      resolve(stdout);
+      resolve({ stdout, stderr });
     });
   });
 }

packages/core/src/dependency-finder/pnpm.ts

@@ -10,7 +10,7 @@ export async function findPnpmDependencies(
   production?: boolean | undefined,
   verbose?: boolean | undefined,
 ): Promise<DependenciesResult> {
-  const output = await execCommand(
+  const { stdout: output } = await execCommand(
     production ? findPnpmProdDepsCommand : findPnpmDepsCommand,
     projectRoot,
     verbose,

packages/core/src/dependency-finder/yarn-classic.ts

@@ -31,7 +31,7 @@ export async function findYarnClassicDependencies(
   production?: boolean | undefined,
   verbose?: boolean | undefined,
 ): Promise<DependenciesResult> {
-  const output = await execCommand(
+  const { stdout: output } = await execCommand(
     production ? findYarnClassicProdDepsCommand : findYarnClassicDepsCommand,
     projectRoot,
     verbose,

test/test/yarn.test.ts

@@ -2,7 +2,7 @@ import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import type { JsonResults } from "@license-auditor/data";
 import { describe, expect } from "vitest";
-import { yarnFixture } from "../fixtures";
+import { yarnFixture, yarnWithInvalidGithubDepFixture } from "../fixtures";
 import { addToPackageJson } from "../utils/add-to-package-json";
 import { getCliPath } from "../utils/get-cli-path";
 import { readJsonFile } from "../utils/read-json-file";
@@ -24,13 +24,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -53,13 +53,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -82,13 +82,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -111,13 +111,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -147,13 +147,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -189,13 +189,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("160 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("160 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -220,13 +220,13 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(0);
+        expect(output).toContain("67 licenses are compliant");
+
         const jsonOutput: JsonResults = await readJsonFile(
           path.join(testDirectory, "license-auditor.results.json"),
         );
 
-        expect(errorCode).toBe(0);
-        expect(output).toContain("67 licenses are compliant");
-
         const addedPackage = jsonOutput.whitelist.find(
           (result) => result.packageName === "test-dep@1.0.0",
         );
@@ -253,13 +253,13 @@ describe("yarn", () => {
         cwd: testDirectory,
       });
 
+      expect(errorCode).toBe(0);
+      expect(output).toContain("66 licenses are compliant");
+
       const jsonOutput: JsonResults = await readJsonFile(
         path.join(testDirectory, "license-auditor.results.json"),
       );
 
-      expect(errorCode).toBe(0);
-      expect(output).toContain("66 licenses are compliant");
-
       const addedPackage = jsonOutput.whitelist.find(
         (result) => result.packageName === "test-dep@1.0.0",
       );
@@ -292,6 +292,7 @@ describe("yarn", () => {
           cwd: testDirectory,
         });
 
+        expect(errorCode).toBe(1);
         expect(output).toContain("Invalid configuration file at");
         expect(output).toContain("Expected array, received string");
         expect(output).toContain("Expected array, received number");