Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI setup #46

Closed
wants to merge 32 commits into from
Closed

feat: CLI setup #46

wants to merge 32 commits into from

Conversation

F-Kublin
Copy link
Collaborator

No description provided.

Angela and others added 29 commits October 3, 2024 11:31
BREAKING CHANGE: introduces changes to package.json and tsconfig
adjust biome config to allow necessary operations and exports
package.json Outdated
@@ -23,6 +23,7 @@
"@tsconfig/recommended": "1.0.7",
"cz-conventional-changelog": "3.3.0",
"husky": "9.1.6",
"tsx": "4.19.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why in the root?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted it usable both in cli and pastel-cli, I can move it up if that's an issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to turborepo documentation: https://turbo.build/repo/docs/crafting-your-repository/managing-dependencies#install-dependencies-where-theyre-used

When you install a dependency in your repository, you should install it directly in the package that uses it. The package's package.json will have every dependency that the package needs. This is true for both external and internal dependencies.

and

The only dependencies that belong in the workspace root are tools for managing the repository

this package isn't for managing the repository so it doesn't belong there

@F-Kublin F-Kublin closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants