Feature/api design #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the IXperienceDataContext interface and its concrete implementation, XperienceDataContext, to centralize the data context in the Xperience by Kentico CMS application. It includes methods for accessing content item, page content, and reusable schema contexts. Additionally, the DependencyInjection.cs file has been updated to register IXperienceDataContext as a scoped service, improving the dependency injection setup. Interface adjustments include the introduction of a marker interface, IProcessor, and an update to IProcessor<T> to inherit from it, enhancing the processor type system. Code organization has been improved with new using directives for better readability and maintainability. These changes collectively improve the application's architecture, making it more organized, modular, and extensible.
This commit introduces significant enhancements to the framework's query handling and caching mechanisms. Specifically, it adds a new private field `_parameters` in `ContentItemContext.cs` and `PageContentContext.cs` to dynamically store query parameters. The constructors of these classes have been updated to initialize this field, ensuring it's ready to store query parameters upon object instantiation. Furthermore, the dynamic handling of query parameters has been improved by populating the `_parameters` collection with parameters extracted from the `QueryParameterManager` using the `GetQueryParameters().ToList()` method. This occurs within a context where expressions are visited to dynamically build up the query parameters. The cache key generation method `GetCacheKey` in both mentioned contexts has been modified to include the hash code of the `_parameters` collection. This ensures that the cache key is unique based on the specific query parameters, improving the accuracy of cached data retrieval. In `QueryParameterManager.cs`, enhancements include the introduction of a new private field `_params` to store query parameters, updates to constructors for initializing this field, and the addition of a `GetQueryParameters` method to return the query parameters collection. The `AddParam` method allows adding new key-value pairs to the `_params` collection, and modifications in various condition handling methods ensure that query parameters are appropriately added to this collection. After applying conditions, the `ApplyConditions` method clears the `_params` collection to reset the state for subsequent queries. These changes collectively improve the framework's ability to construct queries dynamically with varying parameters and enhance cache management by incorporating query-specific details into cache keys.
In both `ContentItemContext.cs` and `PageContentContext.cs` within the `XperienceCommunity.DataContext` namespace, modifications have been made to clear the `_parameters` collection post-fetching results from cache or executing queries asynchronously. This change ensures the reset of any query parameters after each operation, enhancing the reliability and predictability of data fetching operations. Specifically, `_parameters.Clear();` is added after results are obtained from `GetOrCacheAsync` in both contexts, followed by appropriate result handling. This update aims to prevent the unintended reuse of query parameters in subsequent operations.
brandonhenricks
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.