Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the design for the search engine dialog in brave://settings/search #43208

Open
4 tasks
aguscruiz opened this issue Jan 9, 2025 · 2 comments
Open
4 tasks

Update the design for the search engine dialog in brave://settings/search #43208

aguscruiz opened this issue Jan 9, 2025 · 2 comments
Assignees
@rebron
Labels
feature/search feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA/Yes release-notes/include

Comments

@aguscruiz
Copy link

aguscruiz commented Jan 9, 2025 •
edited
Loading

Description

Suggested by @bradleyrichter.

Let's add a flair to the Brave search option in the default search engine selector. This applies to:

  • Regular search engine selector in settings brave://settings/search
  • Private windows selector in settings brave://settings/search

Additionally, if the user is not using Brave search, we show a dismissable banner on the top of the page.

  • When clicked, both search engine defaults should change to Brave Search.
  • If dismissed, the banner doesn't appear again.

Design:

https://www.figma.com/design/IXNCYwXmMWaF6u7Pdv1pOW/Desktop-settings---Nala?node-id=1606-38985&t=q0v78oxKBieNZzce-1

See Figma for potentially updated designs:
Image

Image
@aguscruiz aguscruiz changed the title Add a "recommended" label in Search engine selector of settings Changes to Default search engine page in settings Jan 9, 2025
@fallaciousreasoning
Copy link

This looks pretty cool!

@aguscruiz
Copy link
Author

aguscruiz commented Jan 9, 2025 •
edited
Loading

I assigned it to you before knowing if you'd be working on it, but since you like it... 😆. Don't have final approval yet though. @rebron @bradleyrichter what do you think

@rebron rebron added feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature/search QA/Yes release-notes/include labels Jan 10, 2025
@rebron rebron changed the title Changes to Default search engine page in settings Update the design for the search engine dialog in brave://settings/search Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebron rebron

Labels
feature/search feature/settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA/Yes release-notes/include
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebron @fallaciousreasoning @aguscruiz