Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide custom filters textbox if dev mode is off and there're no custom filters. #27201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Jan 13, 2025

Resolves brave/brave-browser#43258

No filtes and dev mode is off:

image

No filters and dev mode is on:

image

There is a filter and dev mode is off:

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp self-assigned this Jan 13, 2025
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 13, 2025
@boocmp boocmp requested a review from ShivanKaul January 13, 2025 13:26
@boocmp boocmp force-pushed the hide_custom_filters branch from 06bc466 to a8b50b3 Compare January 13, 2025 13:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@ShivanKaul
Copy link
Collaborator

Could we just completely hide the Custom Filters and Custom Scriptlets UI if toggle is OFF? So only show the Custom Filters section if toggle is ON or there's at least one existing filter, and only show Custom Scriptlets section if toggle is ON or if there's at least one existing custom scriptlet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Shields] Hide the custom filters box in settings.
3 participants