Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested Zcash account name should not have a capital C #43278

Closed
3 of 6 tasks
Douglashdaniel opened this issue Jan 14, 2025 · 0 comments · Fixed by brave/brave-core#27222
Closed
3 of 6 tasks

Suggested Zcash account name should not have a capital C #43278

Douglashdaniel opened this issue Jan 14, 2025 · 0 comments · Fixed by brave/brave-core#27222
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include
Milestone
1.76.x - Nightly

Comments

@Douglashdaniel
Copy link

Description

Currently when you go to create a new Zcash account the C is capitalized for the Suggested Name example(ZCash Account 2)

Steps to reproduce

  1. Go to the Accounts tab and then click to create a new Zcash account
  2. The suggested name has a capital C in Zcash

Actual result

Screen.Recording.6.mov

Expected result

c should not be capitalized in Zcash

Screen.Recording.7.mov

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.73.104 Chromium: 131.0.6778.204 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include labels Jan 14, 2025
@Douglashdaniel Douglashdaniel self-assigned this Jan 14, 2025
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 14, 2025
@Douglashdaniel Douglashdaniel mentioned this issue Jan 14, 2025
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jan 14, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 14, 2025
@brave-builds brave-builds added this to the 1.76.x - Nightly milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include
Projects
Web3
Status: Done
Milestone
1.76.x - Nightly
Development

Successfully merging a pull request may close this issue.

fix(wallet): Don't Capitalize c in Zcash Account Name Suggestion brave/brave-core
2 participants
@Douglashdaniel @brave-builds