Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SLIP-0023 for Cardano #27152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement SLIP-0023 for Cardano #27152

wants to merge 3 commits into from

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Jan 8, 2025

Resolves brave/brave-browser#43201
Sec review: https://github.com/brave/reviews/issues/1840

The PR includes:

  • Master key generation from bip-39 entropy.
  • Private child key generation for normal and hardened indexes.
  • Adjusted BoringSSL/OpenSSL methods for pubkey derivation and signing:
    • ED25519_pubkey_from_scalar. Generates pubkey from scalar Ai = [kL]B. Same as part of ED25519_keypair_from_seed but scalar comes from Ed25519_BIP32 algorithm instead of hashed seed
    • ED25519_sign_with_scalar_and_prefix. Same as a part of ED25519_sign. For ED25519_sign private_key[0..31] -> SHA512 -> [scalar, prefix] and private_key[32..63] -> public_key. For ED25519_sign_with_scalar_and_prefix scalar, prefix, public_key come from Ed25519_BIP32 algorithm
    • Also added pseudo random test vectors generated with @cardano-sdk/crypto library

Reference implementations:

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@supermassive supermassive force-pushed the slip23 branch 2 times, most recently from 542f8b5 to b039567 Compare January 9, 2025 09:17
@supermassive supermassive changed the title Slip23 Implement SLIP-0023 for Cardano Jan 9, 2025
@supermassive supermassive marked this pull request as ready for review January 9, 2025 11:35
@supermassive supermassive requested review from a team as code owners January 9, 2025 11:35
@supermassive supermassive force-pushed the slip23 branch 2 times, most recently from 8d42cbd to a639e0a Compare January 13, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SLIP-0023 for Cardano
2 participants