feat(ios): Add a script to push localization resource file to Crowdin #27230
+186
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuo-xu
added
CI/skip-android
| cd $(dirname "$0") | ||
|
|
||
| echo "Exporting strings from Xcode project..." | ||
| (cd ../../ && xcodebuild -exportLocalizations SWIFT_EMIT_LOC_STRINGS=NO) >>output.log 2>&1 |
There was a problem hiding this comment.
If we only ever push up the en.xliff why dont we just only export english here? (-exportLanguage en)
| -H "Authorization: Bearer ${TOKEN}" \ | ||
| -H "Content-Type: application/json" | ||
| ) | ||
| file_id=$(echo "$file_result" | jq '.data.[0].data.id') |
There was a problem hiding this comment.
I dont think jq is a standard bash utility even on macOS, may want to add its requirement to the README
| -H "Content-Type: application/json" | ||
| ) | ||
| file_id=$(echo "$file_result" | jq '.data.[0].data.id') | ||
| if [ $file_id == null ] |
There was a problem hiding this comment.
Is this checking for the string literal "null"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#43271
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: