always pass an int to fromID/fromTabID

auditors @PeteMiller fix brave/browser-laptop#14075
brave · May 9, 2018 · 3bb5db3 · 3bb5db3
1 parent ec2b1fa
commit 3bb5db3
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/lib/browser/api/web-contents.js b/lib/browser/api/web-contents.js
@@ -235,7 +235,14 @@ module.exports = {
   },
 
   fromId (id) {
-    const contents = binding.fromId(id)
+    if (!id)
+      return
+
+    const parsed = parseInt(id)
+    if (isNaN(parsed))
+      return
+
+    const contents = binding.fromId(parsed)
     if (contents && !contents.isDestroyed()) {
       return contents
     }
@@ -248,7 +255,12 @@ module.exports = {
   fromTabID (tabID) {
     if (!tabID)
       return
-    const contents = binding.fromTabID(tabID)
+
+    const parsed = parseInt(tabID)
+    if (isNaN(parsed))
+      return
+
+    const contents = binding.fromTabID(parsed)
     if (contents && !contents.isDestroyed()) {
       return contents
     }