remove circular reference for persistent/private profile

brave · Jun 29, 2016 · 6e31e0e · 6e31e0e
1 parent 76bd4e8
commit 6e31e0e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/atom/browser/atom_browser_context.cc b/atom/browser/atom_browser_context.cc
@@ -100,7 +100,7 @@ AtomBrowserContext::AtomBrowserContext(const std::string& partition,
 #endif
       partition_(partition) {
   if (in_memory) {
-    original_context_ = AtomBrowserContext::From(partition, false);
+    original_context_ = AtomBrowserContext::From(partition, false).get();
     original_context()->otr_context_ = this;
   }
 }
@@ -125,8 +125,10 @@ AtomBrowserContext::~AtomBrowserContext() {
 
   if (otr_context_.get()) {
     // destroy the otr profile
-    otr_context()->user_prefs()->ClearMutableValues();
-    otr_context_.swap(nullptr);
+    auto user_prefs = user_prefs::UserPrefs::Get(otr_context_.get());
+    if (user_prefs)
+      user_prefs->ClearMutableValues();
+    otr_context_ = NULL;
   } else {
     ExtensionPrefValueMapFactory::GetForBrowserContext(this)->
         ClearAllIncognitoSessionOnlyPreferences();
@@ -145,7 +147,7 @@ AtomBrowserContext* AtomBrowserContext::original_context() {
   if (!IsOffTheRecord()) {
     return this;
   }
-  return static_cast<AtomBrowserContext*>(original_context_.get());
+  return static_cast<AtomBrowserContext*>(original_context_);
 }
 
 AtomBrowserContext* AtomBrowserContext::otr_context() {
@@ -314,7 +316,7 @@ void AtomBrowserContext::RegisterUserPrefs() {
       new JsonPrefStore(filepath, task_runner, std::unique_ptr<PrefFilter>());
 
   // prepare factory
-  bool async = false;
+  bool async = true;
   syncable_prefs::PrefServiceSyncableFactory factory;
   factory.set_async(async);
   factory.set_extension_prefs(extension_prefs);

diff --git a/atom/browser/atom_browser_context.h b/atom/browser/atom_browser_context.h
@@ -93,7 +93,7 @@ class AtomBrowserContext : public brightray::BrowserContext {
   AtomCertVerifier* cert_verifier_;
   AtomNetworkDelegate* network_delegate_;
 
-  scoped_refptr<brightray::BrowserContext> original_context_;
+  brightray::BrowserContext* original_context_;
   scoped_refptr<brightray::BrowserContext> otr_context_;
   const std::string partition_;