Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreserve outputs before sending sweep transaction #531

Open
ubbabeck opened this issue Oct 18, 2023 · 4 comments
Open

unreserve outputs before sending sweep transaction #531

ubbabeck opened this issue Oct 18, 2023 · 4 comments

Comments

@ubbabeck
Copy link
Contributor

In order to replace a transaction if eg. fee is too low when transferring from the internal wallet. So it the output is reserved it would be nice to unreserve so the user can broadcast the new transaction.

Ref c-breez issue breez/c-breez#676.

@dangeross
Copy link
Collaborator

Seems the only way to unreserve inputs is using the psbt result of the withdraw. So we need a mechanism to find or cache this tx/psbt

@roeierez
Copy link
Member

roeierez commented Jan 7, 2024

@dangeross I see. The problem is that there could be multiple psbt created in the past each for a set of utxos...
Perhaps we should use a different way to withdraw? create a new psbt (https://docs.corelightning.org/reference/lightning-utxopsbt) and then send it using https://docs.corelightning.org/reference/lightning-signpsbt and https://docs.corelightning.org/reference/lightning-sendpsbt ?
I think this process allows using reserved inputs.

@dangeross
Copy link
Collaborator

Yes, it's possible to use lightning-utxopsdt with already reserved inputs. There is also the option to not reserve the input utxos used to create the psbt. So we could in theory only use not reserved inputs and not reserve them. Something to think about.

@dangeross dangeross self-assigned this Jan 8, 2024
@dangeross
Copy link
Collaborator

dangeross commented Jan 10, 2024

Currently blocked by lightning-addpsbtoutput not being available over cln-grpc

ElementsProject/lightning#6986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants