Change short_channel_id to string #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
reviewed
Sep 10, 2024
| @@ -61,7 +61,7 @@ impl From<BoltzRouteHintHop> for RouteHintHop { | |||
| fn from(value: BoltzRouteHintHop) -> Self { | |||
| RouteHintHop { | |||
| src_node_id: value.node_id, | |||
| short_channel_id: 0_u64, | |||
| short_channel_id: "0".to_string(), | |||
There was a problem hiding this comment.
Suggested change
| short_channel_id: "0".to_string(), | |
| short_channel_id: "0x0x0".to_string(), |
libs/sdk-common/src/invoice.rs
Outdated
| fn parse_short_channel_id(id_str: &str) -> InvoiceResult<u64> { | ||
| let parts: Vec<&str> = id_str.split('x').collect(); | ||
| if parts.len() != 3 { | ||
| return Ok(0); |
There was a problem hiding this comment.
I know this was already there, but shouldn't this return an error?
There was a problem hiding this comment.
Changed to throw an error, also added some tests
roeierez
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
short_channel_idof theRouteHintHopmodel to string in the format: