Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci for swift #620

Closed
wants to merge 7 commits into from
Closed

add ci for swift #620

wants to merge 7 commits into from

Conversation

JssDWt
Copy link
Contributor

@JssDWt JssDWt commented Nov 16, 2023

Move the Swift CI into the sdk repo.
Needs a secret to be set: COCOAPODS_TRUNK_TOKEN

Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing to note is that RN depends on the swift build so right now we will need to publish first the swift and make sure it passes and then run all other platforms unless there is a way to only run RN if swift passes...

@JssDWt
Copy link
Contributor Author

JssDWt commented Nov 17, 2023

LGTM! One thing to note is that RN depends on the swift build so right now we will need to publish first the swift and make sure it passes and then run all other platforms unless there is a way to only run RN if swift passes...

Good point. I'll see if I can make React native run only if swift completes, regardless of whether swift was being built or not.

@JssDWt
Copy link
Contributor Author

JssDWt commented Sep 2, 2024

Closing in favor of #1033

@JssDWt JssDWt closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants