Filter out node logs below Info level #848
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies filter level customization changes on logger from Breez SDK PR:
env_logger
module filters on Dart & UniFFI binding loggers breez-sdk-greenlight#874which addresses the issue raised on:
CONFIG
toINFO
#817where we were receiving unwanted SDK module logs as the filtering mechanism previously did not apply to them on binding loggers.
Reducing default log level from
CONFIG
toINFO
had unwanted side effects such as missing out on node logs as they were all emitted onDebug
level on the SDK, corresponds toCONFIG
level on app layer, which got addressed by increasing their level toInfo
but this is a temporary fix that did not address the underlying issue.The logs that are coming from modules were still not filtered and we were missing out on helpful logs on
Debug
level across the SDK, notification extensions and app. Also, since notification extensions & SDK uses the same log stream, there was no way to differentiate between their filter levels. Which are all addressed by this & SDK PR.Currently, we don't miss information from
Debug
level logs & unwanted SDK module logs are filtered out.Changelist:
CONFIG
fromINFO