Update test fixtures to use string descriptions where tested

[rmosolgo]

👋 I saw that some tests were skipped on GraphQL-Ruby v2.2+, so I took a look into it.

It looks like the new Ruby parser broke it. The old parser supported comments-as-descriptions, but the new parser doesn't. So these tests for descriptions started failing.

I updated these example to use strings instead of comments so that the tests would keep passing. (Strings have been the only "official" format for descriptions since 2018 or so: graphql/graphql-spec#420.)

To update the whole example, we could probably use GraphQL-Ruby 2.1.x do something like GraphQL::Schema.from_definition(...).to_definition to generate a new, spec-compliant schema definition file.

What do you think of this approach? Would it be helpful to update all the fixtures to the current format?

[brettchalupa]

@rmosolgo thank you so much! This makes a lot of sense and helps me understand what changed and why. Updating and validating the fixture schemas would be great, and I could even see adding that to the CI checks to ensure we're valid moving forward.

Would you want to take that on or want me to? Either way. Your contribution is much appreciated, and thanks for your work on graphql-ruby!

[rmosolgo]

Sure thing, happy to! I used this script to regenerate the files:

require 'bundler/inline'

gemfile(true) do
  gem 'graphql', '~>2.1.0'
end

Dir.glob('test/graphql-docs/fixtures/*.graphql').each do |file|
  puts "Transforming #{file}"
  prev_sdl = File.read(file)
  new_sdl = GraphQL::Schema.from_definition(prev_sdl).to_definition
  File.write(file, new_sdl)
  puts '  Done'
end

Then pushed the changes here.

[brettchalupa]

Thanks again @rmosolgo!