From a71fbbfdd4e0ee89abe0032937c3d5bd3ab4d70a Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Wed, 31 Jan 2024 13:43:26 +0800
Subject: [PATCH] ed: simplify debug

* Simplify -d option to become a flag an not take an argument
* The only supported argument was "parse", so this patch makes debugging easier to enable
* The old way with -ddebugstring did not provide any feedback if I typed an unsupported string
* Sync usage string in Usage() and Synopsis
* Remove redundant comment where usage string was also being maintained (but wasn't up to date with -s or -p)
---
 bin/ed | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/bin/ed b/bin/ed
index 966f19ef..ae31ddf8 100755
--- a/bin/ed
+++ b/bin/ed
@@ -29,16 +29,12 @@ License: gpl
 #        - Because working on this is more fun than Y2K testing !
 #
 # Who:
-#
 #        George M Jones (gmj@infinet.com).  Please send changes to me.
 #
 # When:
 #        Version 0.1
 #          - 06/09/99 - Created (note that non-Y2K compliant date !!!)
 #
-# How (Usage):
-#        ed [-ddebugflags] [-v] [-] [file]
-#
 # Irony:  This was, of course, edited originaly with emacs...
 #
 # Commentary:
@@ -154,7 +150,7 @@ $SIG{HUP} = sub {
 
 
 my %opt;
-getopts('d:p:sv', \%opt) or &Usage;
+getopts('dp:sv', \%opt) or Usage();
 if (defined $opt{'p'}) {
     $Prompt = $opt{'p'};
 }
@@ -181,7 +177,7 @@ while (1) {
 
     if (&edParse) {
 
-        if ($opt{'d'} =~ /parse/) {
+        if ($opt{'d'}) {
             print "command: /$command/ ";
             print "adrs[0]: /$adrs[0]/ " if defined($adrs[0]);
             print "adrs[1]: /$adrs[1]/ " if defined($adrs[1]);
@@ -1022,7 +1018,7 @@ sub CalculateLine {
 
     my($myline);
 
-    if ($opt{'d'} =~ /parse/) {
+    if ($opt{'d'}) {
         print "expr1=/$expr1/\n" if (defined($expr1));
         print "decimaladr=/$decimaladr/\n" if (defined($decimaladr));
         print "dotadr=/$dotadr/\n" if (defined($dotadr));
@@ -1131,7 +1127,7 @@ sub edSearchBackward {
 #
 
 sub Usage {
-    die "Usage: ed [-p prompt] [-ddebugstring] [-sv] [file]\n";
+    die "Usage: ed [-p prompt] [-dsv] [file]\n";
 }
 
 #
@@ -1160,7 +1156,7 @@ ed - text editor
 
 =head1 SYNOPSIS
 
-ed [-p prompt] [-ddebugstring] [-sv] [file]
+ed [-p prompt] [-dsv] [file]
 
 =head1 DESCRIPTION
 
@@ -1201,9 +1197,9 @@ The following options are available:
 
 =over 4
 
-=item -ddebugstring
+=item -d
 
-Print debugging output. debugstring may be set to "parse".
+Print debugging information on standard output.
 
 =item -p STRING