From 50e2bc058d12fb9278e6448c4b12954c771e5419 Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Tue, 2 Jan 2024 12:33:39 +0800
Subject: [PATCH] cat: stop accepting -? flag

* Undocumented -? option was accepted by getopt but ignored
* This option doesn't appear in GNU or OpenBSD version
* The only option mentioned by standards document is -u [1], so there is probably no reason to keep -?
* While here, prefix usage string with "usage:"

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/cat.html
---
 bin/cat | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/bin/cat b/bin/cat
index 139f22b3..5b7d5cc9 100755
--- a/bin/cat
+++ b/bin/cat
@@ -23,13 +23,10 @@ my ($VERSION) = '1.3';
 
 my $Program = basename($0);
 
-getopts ('benstuv?', \my %options)  or do {
-	print <<EOF;
-$Program version $VERSION
-$Program [-benstuv] [file ...]
-EOF
-
-	exit EX_FAILURE;
+getopts('benstuv', \my %options)  or do {
+    warn "$Program version $VERSION\n";
+    warn "usage: $Program [-benstuv] [file ...]\n";
+    exit EX_FAILURE;
 };
 
 my $ends              = exists $options{'e'};