From 021927ffc3bcf90865808d16e1d0839dfe6a7275 Mon Sep 17 00:00:00 2001
From: Michael Mikonos <127171689+mknos@users.noreply.github.com>
Date: Sat, 4 Nov 2023 21:10:15 +0800
Subject: [PATCH] mkfifo: common -m usage

* I like to write -m 0 as a shortcut for no-permissions
* Because of truth check "-m 000" invoked get_mode() but "-m 0" did not
* The minimum is 1 digit for mode and -m 7 means 007, but get_mode() expected it always gets 3
* GNU and OpenBSD mkfifo commands accept -m 0, -m 7, -m 75, ...
* Delete commented code
---
 bin/mkfifo | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/bin/mkfifo b/bin/mkfifo
index 663ea07e..f96d6794 100755
--- a/bin/mkfifo
+++ b/bin/mkfifo
@@ -47,9 +47,6 @@ sub sym_perms {
 		$what_mask |= $what{$_};
 	}
 
-#	printf "%o, %o, %o\n", $who_mask, $what_mask, $change;
-#	print "$how\n";
-
 	if ($how eq '+') {
 		$mode |= ($who_mask & $what_mask);
 	} elsif ($how eq '-') {
@@ -63,7 +60,7 @@ sub get_mode {
 	my $mode = shift;
 	my $real_mode;
 
-	if ($mode =~ /^0?[0-7]{3}$/) {
+	if ($mode =~ /^0?[0-7]{1,3}$/) {
 		return $real_mode = oct($mode);
 	}
 	$real_mode = sym_perms $mode;
@@ -71,7 +68,7 @@ sub get_mode {
 	die "bad mode: $mode\n";
 }
 
-my $mode = $opt_m ? get_mode $opt_m : $default_mode;
+my $mode = defined $opt_m ? get_mode($opt_m) : $default_mode;
 
 foreach my $fifo (@ARGV) {
 	mkfifo $fifo, $mode or die "can't make fifo $fifo: $!\n";