Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id: uid 0 is valid #281

Merged
merged 1 commit into from
Oct 10, 2023
Merged

id: uid 0 is valid #281

merged 1 commit into from
Oct 10, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 8, 2023 •
edited
Loading

  • Problem1: id reports that my root user doesn't exist because the uid is zero
  • This is because $uid is undef if getpwnam() fails, but this was treated the same as 0

$ id root
uid=0(root) gid=0(root) groups=0(root),117(lpadmin)
$ perl id root
id: root: No such user

  • Problem2: id reports that 'root77' user exists when it does not
  • This is because a non-numeric parameter was passed to getpwuid()

$ perl id root77
uid=0(root) gid=0(root) groups=117(lpadmin),0(root)

@mknos
id: uid 0 is valid
92678da 
* Problem1: id reports that my root user doesn't exist because the uid is zero
* This is because $uid is undef if getpwnam() fails, but this was treated the same as 0

$ id root
uid=0(root) gid=0(root) groups=0(root),117(lpadmin)
$ perl id root
id: root: No such user

* Problem2: id reports that 'root77' user exists when it does not
* This is because a non-numeric parameter was passed to getpwuid()

$ perl id root77
uid=0(root) gid=0(root) groups=117(lpadmin),0(root)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: id The id program labels Oct 8, 2023
@briandfoy briandfoy self-assigned this Oct 10, 2023
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 10, 2023
@briandfoy briandfoy merged commit ed89d6a into briandfoy:master Oct 10, 2023
2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: id The id program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy