Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: check_number() too forgiving #284

Merged
merged 1 commit into from
Oct 10, 2023
Merged

tail: check_number() too forgiving #284

merged 1 commit into from
Oct 10, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 9, 2023

  • Numbers can optionally be given with '-' or '+' prefix
  • The number validation function allows numbers with leading garbage (regex match was only on end of string)
  • These values were accepted: aaa1 +aaa1 -aaa1
  • We can pass a helpful error message to usage() to indicate which argument was rejected
  • Style: indent check_number()
  • Tested this by passing numbers to -n option

@mknos
tail: check_number() too forgiving
10e79a2 
* Numbers can optionally be given with '-' or '+' prefix
* The number validation function allows numbers with leading garbage (regex match was only on end of string)
* These values were accepted: aaa1 +aaa1 -aaa1
* We can pass a helpful error message to usage() to indicate which argument was rejected
* Style: indent check_number()
* Tested this by passing numbers to -n option
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Oct 9, 2023
@briandfoy briandfoy self-assigned this Oct 10, 2023
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 10, 2023
@briandfoy briandfoy merged commit f873ba0 into briandfoy:master Oct 10, 2023
2 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy