-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bc: runtime error eats too much input #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In interactive bc, calling an undefined function does not cause a fatal error but an error is printed * YYERROR() is called in this situation, but it seems to break something * It appears that input tokens past the end of current statement are eaten by YYERROR * I observed this: ME> x = hey(1) + 2 BC> No function hey() has been defined ME> x ME> x BC> 0 ME> quit * After the error bc ignores the first time I type x (but when I ask again it politely answers) * Replacing YYERROR with "last INSTR" causes bc to jump past the final instruction in the current statement * Instructions in the subsequent statement are not destroyed * With this patch, the statement after the error is executed as I expect (this matches GNU bc) ME> x = 5 BC> 5 ME> y = heh(6) + 7 BC> No function heh() has been defined ME> x BC> 5 ME> y BC> 0 ME> quit
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: bc
The bc program
labels
Oct 14, 2023
I see this, but I want to look at it more closely. The innards of bc are quite complicated. |
|
I have not forgotten about this. I should have time in a week to look at this. I don't think there's a problem but I want to understand the situation first. |
briandfoy
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
briandfoy
added
Status: accepted
The fix is accepted
and removed
Priority: low
get to this whenever
labels
Nov 14, 2023
briandfoy
added
Status: released
there is a new release with this fix
and removed
Status: accepted
The fix is accepted
labels
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: bc
The bc program
Status: released
there is a new release with this fix
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ME> x = hey(1) + 2
BC> No function hey() has been defined
ME> x
ME> x
BC> 0
ME> quit
ME> x = 5
BC> 5
ME> y = heh(6) + 7
BC> No function heh() has been defined
ME> x
BC> 5
ME> y
BC> 0
ME> quit