Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wump: simplify S list init #293

Merged
merged 1 commit into from
Oct 16, 2023
Merged

wump: simplify S list init #293

merged 1 commit into from
Oct 16, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 15, 2023

  • Convert S list init code into data declarations
  • $J and $K aren't intended to be global because functions declare their own $J/$K
  • move_wumpus() was an exception to this but it does not require a global $K
  • S and nested arrays are accessed from element 1, so element 0 is blank

@mknos
wump: simplify S list init
330c79a 
* Convert S list init code into data declarations
* $J and $K aren't intended to be global because functions declare their own $J/$K
* move_wumpus() was an exception to this but it does not require a global $K
* S and nested arrays are accessed from element 1, so element 0 is blank
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: wump The wump program labels Oct 15, 2023
@briandfoy briandfoy self-assigned this Oct 16, 2023
@briandfoy briandfoy self-requested a review October 16, 2023 12:55
@briandfoy briandfoy merged commit 26ce0a8 into briandfoy:master Oct 16, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 16, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: wump The wump program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy