Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail -n: 0 versus +0 versus -0 #296

Merged
merged 1 commit into from
Oct 20, 2023
Merged

tail -n: 0 versus +0 versus -0 #296

merged 1 commit into from
Oct 20, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 20, 2023

  • I wrote a test harness for tail-zero-lines...
    for opt in '-0' '+0' '-n 0' '-n -0' '-n +0' ; do echo "tail $opt"; perl tail $opt in; done;
  • Some cases result in the error: The number cannot be null
  • "tail -n 0" is accepted but "tail -n +0" and "tail -n -0" are not
  • When debugging I found that check_number() is not called for "tail -n 0" (but it should be)
  • check_number() was only called if $opt_b/$opt_c/$opt_n were true
  • NB: GNU tail allows -n 0, but raising error in this version is consistent internally, and with "head -n 0"

* I wrote a test harness for tail-zero-lines:
   for opt in '-0' '+0' '-n 0' '-n -0' '-n +0' ; do echo "tail $opt"; perl tail $opt in; done;
* Some cases result in the error: The number cannot be null
* "tail -n 0" is accepted but "tail -n +0" and "tail -n -0" are not
* When debugging I found that check_number() is not called for "tail -n 0" (but it should be)
* check_number() was only called if $opt_b/$opt_c/$opt_n were true
* NB: GNU tail allows -n 0, but raising error in this version is consistent internally, and with "head -n 0"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Oct 20, 2023
@briandfoy briandfoy self-assigned this Oct 20, 2023
@briandfoy briandfoy merged commit b706363 into briandfoy:master Oct 20, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 23, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants