Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: warn for directory args #298

Merged
merged 1 commit into from
Oct 22, 2023
Merged

tail: warn for directory args #298

merged 1 commit into from
Oct 22, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 21, 2023

  • The -f mode of tail calls tail_f(), passing file & directory arguments as separate params
  • By default handle_args() loops over Files list, not Dirs list, so directory arguments were silently ignored
  • Make the default case follow GNU tail: print a warning for each directory argument, and exit with error code when arguments are done

@mknos
tail: warn for directory args
d271149 
* The -f mode of tail calls tail_f(), passing file & directory arguments as separate params
* By default handle_args() loops over Files list, not Dirs list, so directory arguments were silently ignored
* Make the default case follow GNU tail and print a warning for each directory argument, and exit with error code
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Oct 21, 2023
@briandfoy briandfoy self-assigned this Oct 22, 2023
@briandfoy briandfoy merged commit 195311d into briandfoy:master Oct 22, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy