Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkfifo: common -m usage #312

Merged
merged 1 commit into from
Nov 9, 2023
Merged

mkfifo: common -m usage #312

merged 1 commit into from
Nov 9, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 4, 2023

  • I like to write -m 0 as a shortcut for no-permissions
  • Because of truth check "-m 000" invoked get_mode() but "-m 0" did not
  • The minimum is 1 digit for mode and -m 7 means 007, but get_mode() expected it always gets 3
  • GNU and OpenBSD mkfifo commands accept -m 0, -m 7, -m 75, ...
  • Delete commented code

@mknos
mkfifo: common -m usage
021927f 
* I like to write -m 0 as a shortcut for no-permissions
* Because of truth check "-m 000" invoked get_mode() but "-m 0" did not
* The minimum is 1 digit for mode and -m 7 means 007, but get_mode() expected it always gets 3
* GNU and OpenBSD mkfifo commands accept -m 0, -m 7, -m 75, ...
* Delete commented code
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mkfifo The mkfifo program labels Nov 4, 2023
@briandfoy briandfoy self-assigned this Nov 9, 2023
@briandfoy briandfoy merged commit d9d834d into briandfoy:master Nov 9, 2023
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 9, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mkfifo The mkfifo program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy